Added render_config and splicing_config to create_universe bzlmod #3136
+265
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
crate_universe
branch
4 times, most recently
from
91e43e0 to
d9123b6
Compare
UebelAndre
changed the title
UebelAndre
force-pushed
the
crate_universe
branch
2 times, most recently
from
7435223 to
c216c38
Compare
dzbarsky
reviewed
Dec 24, 2024
dzbarsky
reviewed
Dec 24, 2024
UebelAndre
force-pushed
the
crate_universe
branch
2 times, most recently
from
df88493 to
7cc06e7
Compare
UebelAndre
force-pushed
the
crate_universe
branch
from
7cc06e7 to
648abab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was previously no way to set
render_configvalues withbzlmodandsplicing_configwas a bit awkward in it's current implementation by needing to inline a json encoded string. This change adds atag_classto manage the interaction for each config.