Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rust 1.84.0 #3179

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Added Rust 1.84.0 #3179

merged 4 commits into from
Jan 20, 2025

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Jan 9, 2025

@UebelAndre
Copy link
Collaborator Author

Currently this fails to repin with

+ cd examples/crate_universe/vendor_external/
+ CARGO_BAZEL_REPIN=true
+ bazel run :crates_vendor
Error: Failed to write registry URLs and feature map

Caused by:
    0: Failed to get crate from cache for Package { name: Name("ahash"), version: Version { major: 0, minor: 7, patch: 6 }, source: Some(SourceId { url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("github.com")), port: None, path: "/rust-lang/crates.io-index", query: None, fragment: None }, kind: Registry, precise: Some("locked"), name: None }), checksum: Some(Sha256(fcb51a0695d8f838b1ee009b3fbf66bda078cd64590202a864a8f3e8c4315c47)), dependencies: [Dependency { name: Name("getrandom"), version: Version { major: 0, minor: 2, patch: 10 }, source: Some(SourceId { url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("github.com")), port: None, path: "/rust-lang/crates.io-index", query: None, fragment: None }, kind: Registry, precise: Some("locked"), name: None }) }, Dependency { name: Name("once_cell"), version: Version { major: 1, minor: 18, patch: 0 }, source: Some(SourceId { url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("github.com")), port: None, path: "/rust-lang/crates.io-index", query: None, fragment: None }, kind: Registry, precise: Some("locked"), name: None }) }, Dependency { name: Name("version_check"), version: Version { major: 0, minor: 9, patch: 4 }, source: Some(SourceId { url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("github.com")), port: None, path: "/rust-lang/crates.io-index", query: None, fragment: None }, kind: Registry, precise: Some("locked"), name: None }) }], replace: None }
    1: No such file or directory (os error 2)
ERROR: /private/var/tmp/_bazel_user/5f9b22deab82162fb4591147bb665052/external/rules_rust~/crate_universe/private/common_utils.bzl:55:13: Traceback (most recent call last):
	File "/private/var/tmp/_bazel_user/5f9b22deab82162fb4591147bb665052/external/rules_rust~/crate_universe/extensions.bzl", line 949, column 37, in _crate_impl
		_generate_hub_and_spokes(
	File "/private/var/tmp/_bazel_user/5f9b22deab82162fb4591147bb665052/external/rules_rust~/crate_universe/extensions.bzl", line 585, column 51, in _generate_hub_and_spokes
		splice_outputs = splice_workspace_manifest(
	File "/private/var/tmp/_bazel_user/5f9b22deab82162fb4591147bb665052/external/rules_rust~/crate_universe/private/splicing_utils.bzl", line 170, column 19, in splice_workspace_manifest
		cargo_bazel_fn(
	File "/private/var/tmp/_bazel_user/5f9b22deab82162fb4591147bb665052/external/rules_rust~/crate_universe/private/common_utils.bzl", line 88, column 23, in _execute
		return execute(
	File "/private/var/tmp/_bazel_user/5f9b22deab82162fb4591147bb665052/external/rules_rust~/crate_universe/private/common_utils.bzl", line 55, column 13, in execute
		fail(_EXECUTE_ERROR_MESSAGE.format(
Error in fail: Command [/private/var/tmp/_bazel_user/5f9b22deab82162fb4591147bb665052/external/rules_rust~~cu_nr~cargo_bazel_bootstrap/cargo-bazel, "splice", "--output-dir", /private/var/tmp/_bazel_user/5f9b22deab82162fb4591147bb665052/modextwd/rules_rust~~crate/crate_index_cargo_bindeps/splicing-output, "--splicing-manifest", /private/var/tmp/_bazel_user/5f9b22deab82162fb4591147bb665052/modextwd/rules_rust~~crate/crate_index_cargo_bindeps/splicing_manifest.json, "--config", /private/var/tmp/_bazel_user/5f9b22deab82162fb4591147bb665052/modextwd/rules_rust~~crate/crate_index_cargo_bindeps/config.json, "--cargo-lockfile", /Users/user/Code/rules_rust/examples/crate_universe/cargo_bindeps/Cargo.lock, "--cargo", "/private/var/tmp/_bazel_user/5f9b22deab82162fb4591147bb665052/external/rules_rust~~rust_host_tools~rust_host_tools_nightly/bin/cargo", "--rustc", "/private/var/tmp/_bazel_user/5f9b22deab82162fb4591147bb665052/external/rules_rust~~rust_host_tools~rust_host_tools_nightly/bin/rustc"] failed with exit code 1.
STDOUT ------------------------------------------------------------------------

STDERR ------------------------------------------------------------------------
Error: Failed to write registry URLs and feature map

Caused by:
    0: Failed to get crate from cache for Package { name: Name("ahash"), version: Version { major: 0, minor: 7, patch: 6 }, source: Some(SourceId { url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("github.com")), port: None, path: "/rust-lang/crates.io-index", query: None, fragment: None }, kind: Registry, precise: Some("locked"), name: None }), checksum: Some(Sha256(fcb51a0695d8f838b1ee009b3fbf66bda078cd64590202a864a8f3e8c4315c47)), dependencies: [Dependency { name: Name("getrandom"), version: Version { major: 0, minor: 2, patch: 10 }, source: Some(SourceId { url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("github.com")), port: None, path: "/rust-lang/crates.io-index", query: None, fragment: None }, kind: Registry, precise: Some("locked"), name: None }) }, Dependency { name: Name("once_cell"), version: Version { major: 1, minor: 18, patch: 0 }, source: Some(SourceId { url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("github.com")), port: None, path: "/rust-lang/crates.io-index", query: None, fragment: None }, kind: Registry, precise: Some("locked"), name: None }) }, Dependency { name: Name("version_check"), version: Version { major: 0, minor: 9, patch: 4 }, source: Some(SourceId { url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("github.com")), port: None, path: "/rust-lang/crates.io-index", query: None, fragment: None }, kind: Registry, precise: Some("locked"), name: None }) }], replace: None }
    1: No such file or directory (os error 2)

@illicitonion I haven't yet dug too deeply into this but does this error seem familiar to you somehow?

@UebelAndre
Copy link
Collaborator Author

re #3179 (comment)

Found the root cause and filed frewsxcv/rust-crates-index#182

@@ -31,7 +31,7 @@ load(":providers.bzl", "CrateGroupInfo", "CrateInfo", "DepInfo", "DepVariantInfo
#
# Note: Code in `.github/workflows/crate_universe.yaml` looks for this line, if
# you remove it or change its format, you will also need to update that code.
DEFAULT_RUST_VERSION = "1.83.0"
DEFAULT_RUST_VERSION = "1.84.0"

DEFAULT_NIGHTLY_ISO_DATE = "2024-11-28"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not being updated due to frewsxcv/rust-crates-index#182

@UebelAndre UebelAndre force-pushed the rustup branch 4 times, most recently from 2e0b757 to 2911338 Compare January 20, 2025 18:38
@UebelAndre UebelAndre added this pull request to the merge queue Jan 20, 2025
Merged via the queue into bazelbuild:main with commit 281d270 Jan 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants