Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganized sub-workspace dependencies #398

Merged
merged 5 commits into from
Sep 9, 2020
Merged

Reorganized sub-workspace dependencies #398

merged 5 commits into from
Sep 9, 2020

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Sep 7, 2020

This pull request contains various cleanup/quality-of-life improvements for the repository by clearly grouping and defining dependencies for the docs and examples workspaces. Ultimately, the files that are created in here can be moved entirely into their neighboring WORKSPACE files once bazelbuild/bazel#1943 has been closed.

@UebelAndre
Copy link
Collaborator Author

Hey @mfarrugi would you be able to do a review here and potentially on #399 and #402?

@UebelAndre UebelAndre changed the title Workspace cleanup Reorganzied subworkspace dependencies Sep 9, 2020
Copy link
Collaborator

@damienmg damienmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most looks good, I just have 2 remarks (and a typo in the title of the PR).

.bazelignore Show resolved Hide resolved
docs/update_docs.sh Outdated Show resolved Hide resolved
@damienmg damienmg changed the title Reorganzied subworkspace dependencies Reorganizied subworkspace dependencies Sep 9, 2020
@damienmg damienmg changed the title Reorganizied subworkspace dependencies Reorganized subworkspace dependencies Sep 9, 2020
@UebelAndre UebelAndre changed the title Reorganized subworkspace dependencies Reorganized sub-workspace dependencies Sep 9, 2020
@damienmg damienmg merged commit 7d9e890 into bazelbuild:master Sep 9, 2020
@UebelAndre UebelAndre deleted the workspace_cleanup branch September 9, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants