Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler diagnostics for scala 3 are missing. #1602

Closed
ValdemarGr opened this issue Aug 25, 2024 · 2 comments · Fixed by #1611
Closed

Compiler diagnostics for scala 3 are missing. #1602

ValdemarGr opened this issue Aug 25, 2024 · 2 comments · Fixed by #1611

Comments

@ValdemarGr
Copy link

The current Scala 3 diagnostics reporter looks like it is a noop.

It looks like the scala 3 compiler has a ConsoleReporter here. Are there any obstacles for implementing it like the scala 2 variant?
@ValdemarGr ValdemarGr mentioned this issue Aug 25, 2024
Closed
@WojciechMazur
Copy link
Contributor

I've started to work on that, but I cannot assign myself to the issue.
I'm getting strange cyclic inheritance errors when extending 'dotc.reporting.ConsoleReporter'. Might need to check if Scala compiler does not produce something strange in the byte code

susliko added a commit to susliko/rules_scala that referenced this issue Sep 4, 2024
@susliko
Implement diagnostics for Scala 3 (bazelbuild#1602)
9e591a4
susliko added a commit to susliko/rules_scala that referenced this issue Sep 4, 2024
@susliko
Implement diagnostics for Scala 3 (bazelbuild#1602)
c9ddc80
@susliko susliko mentioned this issue Sep 4, 2024
Closed
@susliko
Copy link

susliko commented Sep 4, 2024 •
edited
Loading

@WojciechMazur I also was working on this today, haven't noticed your comment 😓

Looks like I've got it working, but there are no tests yet.

It would be great to join efforts on this.

strange cyclic inheritance errors when extending 'dotc.reporting.ConsoleReporter'.

I chose composition over inheritance 🙂

susliko added a commit to susliko/rules_scala that referenced this issue Sep 4, 2024
@susliko
Implement diagnostics for Scala 3 (bazelbuild#1602)
38a14f2
@WojciechMazur WojciechMazur mentioned this issue Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@susliko @WojciechMazur @ValdemarGr