Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect diagnostics in Scala 3 #1611

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

WojciechMazur
Copy link
Contributor

@WojciechMazur WojciechMazur commented Sep 4, 2024

Description

  • Port ProtoReporter and DepsTrackingReporter to Scala 3
  • Adapt ScalacInvoker to use new reports in Scala 3
  • Enable reports tests for Scala 3 (test_scala_version). Mitigate differences in warnings/errors/info reported by Scala 3 and Scala 2 by introducing a dedicated test cases

Additional info:

Would conflict with #1606 in ScalacInvoker for Scala 3
Required workaround for scala/scala3#21533 - we cannot extend ConsoleReporter in Scala 3 directly. I've decided to port exact behaviour of scalac ConsoleReporter to allow for the most identical semantics across different build tools.
I'm also going to remove tech-debt between all 4 implementations of ProtoReporter/ProtocReporter by introducing a common abstraction in the follow-up PR

Motivation

Fixes #1602

Copy link
Collaborator

@simuons simuons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @WojciechMazur, thanks for this PR, looks good to me, sorry for delay. Could you please rebase this PR on master? Then I'll merge it once green.

@WojciechMazur
Copy link
Contributor Author

Thank you for taking care of that, I've made a rebase.
I'm also preparing a port of dependency_analyzer compiler plugin that is missing for Scala 3. It should finally introduce parity for most of Scala 2 and 3 features and would take advantage of DepsTrackingReporter introduced in this PR.

@simuons simuons merged commit 91a45f7 into bazelbuild:master Oct 24, 2024
2 checks passed
@WojciechMazur WojciechMazur deleted the scala3/diagnostics branch October 25, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler diagnostics for scala 3 are missing.
2 participants