Remove to-be-removed flags from default_java_toolchain #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to fix issue bazelbuild#1224 Test java_toolchain_javacopts_are_used only cares about javacopts bootclasspath and javac are irrelevant and shuold be taked from DEFAULT_TOOLCHAIN_CONFIGURATION/BASE_TOOLCHAIN_CONFIGURATION
liucijus
approved these changes
Feb 22, 2021
ittaiz
approved these changes
Feb 22, 2021
wisechengyi
pushed a commit
to twitter-forks/rules_scala
that referenced
this pull request
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to fix #1224
Test
java_toolchain_javacopts_are_usedfails because of failingdefault_java_toolchaindeclaration.Root cause is that
javacparameter was removed fromjava_toolchain.Test
java_toolchain_javacopts_are_usedonly cares aboutjavacoptsflag on a toolchain.So this PR removes
bootclasspathandjavacfromdefault_java_toolchainand these values will be taken from DEFAULT_TOOLCHAIN_CONFIGURATION/_BASE_TOOLCHAIN_CONFIGURATION