Conditionally set -Djava.security.manager=allow for jdk >= 17 #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an emergency pr to make build pass on ci Probably tool_java_runtime_version started to resolve to jdk 21 And builds are failing with `java.lang.UnsupportedOperationException: The Security Manager is deprecated and will be removed in a future release` Need to solve bazelbuild#1539 asap
simuons
changed the title
KevinBoyette
pushed a commit
to KevinBoyette/rules_scala
that referenced
this pull request
Mar 20, 2024
…uild#1555) Conditionally set -Djava.security.manager=allow for jdk >= 17 rules_scala uses SecurityManager which is deprecated and fails at runtime on jdk21+ (no replacement for this yet) Bazel's approach to solve this is conditionally add a jvm flag see bazelbuild/bazel#14502 CI builds were failing for some time because jdk was updated to 21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally set
-Djava.security.manager=allowfor jdk >= 17Description
rules_scala uses SecurityManager which is deprecated and fails at runtime on jdk21+ (no replacement for this yet)
Bazel's approach to solve this is conditionally add a jvm flag see bazelbuild/bazel#14502
CI builds were failing for some time because jdk was updated to 21
Motivation
Resolves #1521
Duplicate of #1539