Don't rely on global SCALA_VERSION in BUILD files, use select instead
#1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aszady
force-pushed
the
select-build
branch
2 times, most recently
from
1607689
to
c3cc533
Compare
simuons
approved these changes
Apr 23, 2024
liucijus
approved these changes
Apr 24, 2024
|
Thanks, @aszady! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The second part (after #1559) of eliminating dependencies on
SCALA_VERSION. This time within target attributes. Together with #1560 we should be all done.This change extensively uses the new
select_for_scala_versionmacro (#1563).I tried my best to emerge the most correct intention, but in many cases the choice is rather arbitrary (e.g.
any_2+any_3vs.before_3+since_3vs.any_2+default)Motivation
#1290.