Scala 3.5.0 support #1604
Merged
Scala 3.5.0 support #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simuons
approved these changes
Sep 2, 2024
|
@liucijus conflicts are resolved now :) |
|
@liucijus can you please help with merging & maybe releasing this PR? |
mbland
added a commit
to mbland/rules_scala
that referenced
this pull request
Oct 21, 2024
Part of bazelbuild#1482. Avoids a future Scala 3.5 compatibility issue under Bzlmod. PR bazelbuild#1604 added Scala 3.5 suppport. I updated my Bzlmod working branch to include those changes, and updated `scala_3_5.bzl` with dependencies I'd added or updated from `scala_3_4.bzl`. `./test_examples.sh` then failed with the following error, which I recreated in the local `examples/scala3` repo: ```txt $ bazel build --repo_env=SCALA_VERSION=3.5.0 //... ERROR: .../external/rules_scala~/third_party/dependency_analyzer/src/main/BUILD:4:39: scala @@rules_scala~//third_party/dependency_analyzer/src/main:dependency_analyzer failed: (Exit 1): scalac_bootstrap failed: error executing Scalac command (from target @@rules_scala~//third_party/dependency_analyzer/src/main:dependency_analyzer) bazel-out/.../bin/external/rules_scala~/src/java/io/bazel/rulesscala/scalac/scalac_bootstrap ... (remaining 1 argument skipped) -- [E164] Declaration Error: external/rules_scala~/third_party/dependency_analyzer/src/main/io/bazel/rulesscala/dependencyanalyzer3/DependencyAnalyzer.scala:21:6 21 | def init(options: List[String]): List[PluginPhase] = | ^ |error overriding method init in trait StandardPlugin of type (options: List[String]): List[dotty.tools.dotc.plugins.PluginPhase]; | method init of type (options: List[String]): List[dotty.tools.dotc.plugins.PluginPhase] needs `override` modifier ``` This may be because I bumped `io_bazel_rules_scala_scala_library_2` from `org.scala-lang:scala-library:2.13.12` to 2.13.14 in my Bzlmod branch. That's my guess based on information about the `dotty` packages from the following files: - `third_party/utils/src/test/io/bazel/rulesscala/utils/Scala3CompilerUtils.scala` - `third_party/dependency_analyzer/src/test/analyzer_test_scala_3.bzl` It's interesting that Scala 3.{1,2,3,4} all passed with that `scala-library` version bump, but without this change, but I can't explain why.
simuons
pushed a commit
that referenced
this pull request
Oct 23, 2024
Part of #1482. Avoids a future Scala 3.5 compatibility issue under Bzlmod. PR #1604 added Scala 3.5 suppport. I updated my Bzlmod working branch to include those changes, and updated `scala_3_5.bzl` with dependencies I'd added or updated from `scala_3_4.bzl`. `./test_examples.sh` then failed with the following error, which I recreated in the local `examples/scala3` repo: ```txt $ bazel build --repo_env=SCALA_VERSION=3.5.0 //... ERROR: .../external/rules_scala~/third_party/dependency_analyzer/src/main/BUILD:4:39: scala @@rules_scala~//third_party/dependency_analyzer/src/main:dependency_analyzer failed: (Exit 1): scalac_bootstrap failed: error executing Scalac command (from target @@rules_scala~//third_party/dependency_analyzer/src/main:dependency_analyzer) bazel-out/.../bin/external/rules_scala~/src/java/io/bazel/rulesscala/scalac/scalac_bootstrap ... (remaining 1 argument skipped) -- [E164] Declaration Error: external/rules_scala~/third_party/dependency_analyzer/src/main/io/bazel/rulesscala/dependencyanalyzer3/DependencyAnalyzer.scala:21:6 21 | def init(options: List[String]): List[PluginPhase] = | ^ |error overriding method init in trait StandardPlugin of type (options: List[String]): List[dotty.tools.dotc.plugins.PluginPhase]; | method init of type (options: List[String]): List[dotty.tools.dotc.plugins.PluginPhase] needs `override` modifier ``` This may be because I bumped `io_bazel_rules_scala_scala_library_2` from `org.scala-lang:scala-library:2.13.12` to 2.13.14 in my Bzlmod branch. That's my guess based on information about the `dotty` packages from the following files: - `third_party/utils/src/test/io/bazel/rulesscala/utils/Scala3CompilerUtils.scala` - `third_party/dependency_analyzer/src/test/analyzer_test_scala_3.bzl` It's interesting that Scala 3.{1,2,3,4} all passed with that `scala-library` version bump, but without this change, but I can't explain why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Merge after PR #1603)
Motivation
There are newer versions of Scala that can be supported.