Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junit (and specs2) tests now output logs with content #228

Merged
merged 3 commits into from
Jun 14, 2017

Conversation

ittaiz
Copy link
Member

@ittaiz ittaiz commented Jun 13, 2017

Moved to using Bazel's Junit runner which apparently was already open.
based on @natansil's previous work on scala.bzl but without the code from Bazel.
Also changed the existing junit logs test to actually check that the test-cases are actually printed to the xml log file. Test was red and with the change it passed! :)
cc @chaoren

@ittaiz ittaiz force-pushed the use_bazel_junit_test_runner branch from 2a91414 to b1dbe1a Compare June 13, 2017 12:58
@ittaiz
Copy link
Member Author

ittaiz commented Jun 13, 2017

the test is failing on linux. not sure why.
@or-shachar @johnynek would appreciate any ideas if you have any.
Trying to run it now on a remote linux machine I have but bazel build is failing there on

____[440 / 779] Writing file test/src/main/scala/scala/test/large_classpath/dependency_dependency_dependency_dependency_dependency_dependency_dependency_dependency_dependency_dependency_dependency_dependency_dependency_dependency_dependency_dependency_dependency_dependency_dependency_dependency_67_MANIFEST.MF
____[527 / 934] Writing file test/src/main/scala/scala/test/resource_jars/resource_jars_worker_input
____[562 / 994] Creating source manifest for //src/scala/scripts:generator [for host]
____[581 / 1,013] Writing file test/src/main/scala/scala/test/twitter_scrooge/scrooge3_MANIFEST.MF
____[589 / 1,024] Extracting interface @scrooge_core//jar:jar
ERROR: /root/.cache/bazel/_bazel_root/8ebc253a2f259764cbc03f2ee667a0ac/external/scala/BUILD.bazel:15:1: Extracting interface @scala//:scala-library failed: Process exited with status 1 [sandboxed].
src/main/tools/linux-sandbox-pid1.cc:193: "mount(/tmp, /tmp, NULL, MS_BIND, NULL)": Invalid argument

@ittaiz
Copy link
Member Author

ittaiz commented Jun 13, 2017

got this now on the remote machine:

ERROR: /root/.cache/bazel/_bazel_root/8ebc253a2f259764cbc03f2ee667a0ac/external/io_bazel_rules_scala_org_openjdk_jmh_jmh_generator_reflection/jar/BUILD.bazel:2:1: Extracting interface @io_bazel_rules_scala_org_openjdk_jmh_jmh_generator_reflection//jar:jar failed: Process exited with status 1 [sandboxed].
src/main/tools/linux-sandbox-pid1.cc:193: "mount(/tmp, /tmp, NULL, MS_BIND, NULL)": Invalid argument

@johnynek
Copy link
Member

some kind of sandboxing error it seems like you are getting. But travis is seeing something else: that the xml is not being generated but no other error, right?

@ittaiz
Copy link
Member Author

ittaiz commented Jun 13, 2017 via email

@ittaiz
Copy link
Member Author

ittaiz commented Jun 14, 2017

@johnynek solved the problem. Apparently grep on linux doesn't like escaping of single quote with \. Removed it and it works on mac and linux. I'll merge when green :)

@ittaiz ittaiz merged commit 5d6ff51 into master Jun 14, 2017
@ittaiz ittaiz deleted the use_bazel_junit_test_runner branch June 15, 2017 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants