Ignore JMH in reproducibility tests #702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something seems to be wrong there |
|
It's totally not working, yet ;) |
|
we should diagnose what is going on there, but at least we don't depend on jmh in other targets, so I think it shouldn't really be a problem. |
|
seems that #791 handled this. |
gergelyfabian
pushed a commit
to gergelyfabian/rules_scala
that referenced
this pull request
May 31, 2022
…azelbuild#702) This allows to unambiguously relate classes to source files in case of multiple top level classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses .bazelignore to ignore the JMH paths during the reproducibility test.
This solution was quick and easy. Alternatively, you could perhaps filter targets by tags (and add tags on the jmh targets).