Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try new bazel #786

Closed
wants to merge 3 commits into from
Closed

Try new bazel #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99cf509
Try new bazel
ianoc-stripe Jul 16, 2019
5eee427
Cp
ianoc-stripe Jul 16, 2019
98ed294
Cp
ianoc-stripe Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ env:
# See https://github.com/bazelbuild/rules_scala/pull/622
# we want to test the last release
#- V=0.16.1 TEST_SCRIPT=test_lint.sh
- V=0.23.1 TEST_SCRIPT=test_rules_scala
- V=0.28.0 TEST_SCRIPT=test_rules_scala
#- V=0.14.1 TEST_SCRIPT=test_intellij_aspect.sh
- V=0.23.1 TEST_SCRIPT=test_reproducibility
- V=0.28.0 TEST_SCRIPT=test_reproducibility


before_install:
Expand Down
5 changes: 5 additions & 0 deletions src/scala/scripts/ScalaPBGenerator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ class ScalaPBGenerator extends Processor {
val relativePath = root.relativize(fullPath)

relativePath.toFile.getParentFile.mkdirs
// After bazel 0.28 or so, it seems like this shouldn't be required anymore with the virtual imports

if(relativePath.toFile.exists)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you missing { } or something? seems like this is just printing an error message if the file exists.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, sorry i wanted to get travis ci to run everything... and have to open a PR to do that. But looks like from the first commit something else blows up for 0.28 before it actually gets to trying out this code.

System.err.println(s"Copying ${fullPath} to ${relativePath}")

Files.copy(fullPath, relativePath)
}
}
Expand Down