Skip to content

Commit

Permalink
Address remaining nits/comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jerrymarino committed Jun 9, 2021
1 parent 601e76e commit 006f033
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 16 deletions.
1 change: 0 additions & 1 deletion swift/internal/compiling.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -2190,7 +2190,6 @@ def _declare_compile_outputs(
feature_configuration = feature_configuration,
feature_name = SWIFT_FEATURE_INDEX_WHILE_BUILDING,
)

if (
index_while_building and
not _index_store_path_overridden(user_compile_flags)
Expand Down
14 changes: 0 additions & 14 deletions swift/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -123,20 +123,6 @@ native_binary(
out = "index-import",
visibility = ["//visibility:public"],
)
native_binary(
name = "validate_index",
src = "validate-index",
out = "validate-index",
visibility = ["//visibility:public"],
)
native_binary(
name = "absolute_unit",
src = "absolute-unit",
out = "absolute-unit",
visibility = ["//visibility:public"],
)
""",
canonical_id = "index-import-5.3.2.6",
urls = ["https://github.com/MobileNativeFoundation/index-import/releases/download/5.3.2.6/index-import.zip"],
Expand Down
2 changes: 1 addition & 1 deletion tools/worker/swift_runner.cc
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ int SwiftRunner::Run(std::ostream *stderr_stream, bool stdout_to_stderr) {
exit_code = RunSubProcess(rewriter_args, stderr_stream, stdout_to_stderr);
}

auto exec_root = GetCurrentDirectory();
auto enable_global_index_store = global_index_store_import_path_ != "";
if (enable_global_index_store) {
OutputFileMap output_file_map;
Expand Down Expand Up @@ -160,6 +159,7 @@ int SwiftRunner::Run(std::ostream *stderr_stream, bool stdout_to_stderr) {
}
}

auto exec_root = GetCurrentDirectory();
// Copy back from the global index store to bazel's index store
ii_args.push_back(exec_root + "/" + global_index_store_import_path_);
ii_args.push_back(exec_root + "/" + index_store_path_);
Expand Down

0 comments on commit 006f033

Please sign in to comment.