Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace --swiftcopt with starlark flag #1139

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

keith
Copy link
Member

@keith keith commented Nov 27, 2023

The Swift configuration fragment is being removed from bazel, this adds
the starlark flags necessary to replace the functionality. This differs
from the upstream solution since google doesn't have a need to support a
--host_swiftcopt replacement

(cherry picked from commit 8be7247)

The Swift configuration fragment is being removed from bazel, this adds
the starlark flags necessary to replace the functionality. This differs
from the upstream solution since google doesn't have a need to support a
--host_swiftcopt replacement

(cherry picked from commit 8be7247)
@keith keith force-pushed the ks/replace-swiftcopt-with-starlark-flag branch from a7bf722 to 30ac05f Compare November 27, 2023 20:41
@keith
Copy link
Member Author

keith commented Nov 27, 2023

This can be used with --flag_alias to make the calling syntax more concise:

  --flag_alias=host_scopt=@build_bazel_rules_swift//swift:exec_copt
  --flag_alias=scopt=@build_bazel_rules_swift//swift:copt

Looks to me like it's safe to make those aliases swiftcopt and host_swiftcopt to mirror the flags that exist today, but that might be too confusing until those are gone for good from bazel

keith referenced this pull request Nov 27, 2023
…ve `--swiftcopt` flag in Bazel.

PiperOrigin-RevId: 584323059
@brentleyjones
Copy link
Collaborator

95f49c9

PiperOrigin-RevId: 585977177
(cherry picked from commit 95f49c9)
keith referenced this pull request Nov 28, 2023
PiperOrigin-RevId: 585977177
@keith
Copy link
Member Author

keith commented Nov 28, 2023

added that one here

@keith keith merged commit 7c82ef1 into master Dec 4, 2023
11 checks passed
@keith keith deleted the ks/replace-swiftcopt-with-starlark-flag branch December 4, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants