Add feature to propagate the generated module map #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
force-pushed
the
bj/propogate_generated_modulemap
branch
from
018221a
to
cb38c6f
Compare
cgrindel
pushed a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Jun 12, 2024
Fixes the tokenizer and modulemap parser to support C99 formatted comments. This is probably not amazing but we'll be able to move off this soon: bazelbuild/rules_swift#1212
brentleyjones
force-pushed
the
bj/propogate_generated_modulemap
branch
4 times, most recently
from
5dba983
to
09fba32
Compare
|
@mattrobmattrob I added an example which fails on CI when the new feature isn't passed. |
brentleyjones
force-pushed
the
bj/propogate_generated_modulemap
branch
3 times, most recently
from
87b40d5
to
8bd59f8
Compare
mattrobmattrob
approved these changes
Jun 14, 2024
Allows `objc_library` to modularly import `swift_library` targets without having to generate a similar module map.
brentleyjones
force-pushed
the
bj/propogate_generated_modulemap
branch
from
8bd59f8
to
78cd04b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
objc_libraryto modularly importswift_librarytargets without having to generate a similar module map.