Introduce the swift_common.get_toolchain helper function
#1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
referenced
this pull request
Jun 19, 2024
This is change 1 of _N_ to migrate the Swift build rules to use new-style Bazel toolchains. This change: * Updates the toolchain configuration rules to wrap the `SwiftToolchainInfo` provider in `platform_common.ToolchainInfo`, for future use by `toolchain()` rules. * Funnels all toolchain access through a new `swift_toolchain.get_toolchain()` function that looks up the toolchain using `ctx.toolchains`, falling back to the implicit attribute. Since `ctx.toolchains` isn't defined yet, the second change is a no-op but it simplifies future parts of the migration. PiperOrigin-RevId: 439638938
brentleyjones
changed the title
swift_common.get_toolchain helper function
brentleyjones
force-pushed
the
bj/cp-884e54426535acb820c746ccff074546b5796402
branch
from
444dcab
to
a39ee60
Compare
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
force-pushed
the
bj/cp-884e54426535acb820c746ccff074546b5796402
branch
2 times, most recently
from
31078e8
to
f58ae29
Compare
This is change 1 of _N_ to migrate the Swift build rules to use new-style Bazel toolchains. This change: * Updates the toolchain configuration rules to wrap the `SwiftToolchainInfo` provider in `platform_common.ToolchainInfo`, for future use by `toolchain()` rules. * Funnels all toolchain access through a new `swift_toolchain.get_toolchain()` function that looks up the toolchain using `ctx.toolchains`, falling back to the implicit attribute. Since `ctx.toolchains` isn't defined yet, the second change is a no-op but it simplifies future parts of the migration. PiperOrigin-RevId: 439638938 (cherry picked from commit 884e544) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/cp-884e54426535acb820c746ccff074546b5796402
branch
from
f58ae29
to
3c645d6
Compare
thii
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is change 1 of N to migrate the Swift build rules to use new-style Bazel toolchains. This change:
SwiftToolchainInfoprovider inplatform_common.ToolchainInfo, for future use bytoolchain()rules.swift_toolchain.get_toolchain()function that looks up the toolchain usingctx.toolchains, falling back to the implicit attribute.Since
ctx.toolchainsisn't defined yet, the second change is a no-op but it simplifies future parts of the migration.PiperOrigin-RevId: 439638938
(cherry picked from commit 884e544)