When calculating the target triple for 'arm64-apple-ios<version>-simulator' targets, correctly specify the minimum supported OS #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lator' targets, correctly specify the minimum supported OS Precompiled pcm files will be generated with the target triple, however the minimum supported version for arm64 on an ios-simulator is 14.0. Any minimum OS under 14 will be raised to 14 by the swift driver and clang tools. This logic is not applied to the AST serialized into pcm object files. To ensure the AST is correctly specified, adjust the target triple to configure the lower bounds correctly. PiperOrigin-RevId: 458248769 (cherry picked from commit b100c3f) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Jun 21, 2024
…lator' targets, correctly specify the minimum supported OS. Precompiled pcm files will be generated with the target triple, however the minimum supported version for arm64 on an ios-simulator is 14.0. Any minimum OS under 14 will be raised to 14 by the swift driver and clang tools. This logic is not applied to the AST serialized into pcm object files. To ensure the AST is correctly specified, adjust the target triple to configure the lower bounds correctly. PiperOrigin-RevId: 458248769
thii
approved these changes
Jun 21, 2024
brentleyjones
deleted the
bj/when-calculating-the-target-triple-for-arm64-apple-ios-version-simulator-targets-correctly-specify-the-minimum-supported-os
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precompiled pcm files will be generated with the target triple, however the minimum supported version for arm64 on an ios-simulator is 14.0. Any minimum OS under 14 will be raised to 14 by the swift driver and clang tools. This logic is not applied to the AST serialized into pcm object files. To ensure the AST is correctly specified, adjust the target triple to configure the lower bounds correctly.
PiperOrigin-RevId: 458248769
(cherry picked from commit b100c3f)