Add a feature to always include all headers as inputs to SwiftCompile actions, even when using explicit modules #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… actions, even when using explicit modules When building with explicit modules, Swift compilations do not require any of the headers to be present on disk, because the AST contains all the necessary information (save for a bug(?) in `canImport` which fails if the headers aren't also present). However, other tooling may want to inspect compilation actions and have access to those headers. This feature is a no-op for implicit module builds, since the headers are always included to begin with, and it is off by default. PiperOrigin-RevId: 461668350 (cherry picked from commit 81f7b54) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Jun 21, 2024
… actions, even when using explicit modules. When building with explicit modules, Swift compilations do not require any of the headers to be present on disk, because the AST contains all the necessary information (save for a bug(?) in `canImport` which fails if the headers aren't also present). However, other tooling may want to inspect compilation actions and have access to those headers. This feature is a no-op for implicit module builds, since the headers are always included to begin with, and it is off by default. PiperOrigin-RevId: 461668350
thii
approved these changes
Jun 21, 2024
brentleyjones
deleted the
bj/add-a-feature-to-always-include-all-headers-as-inputs-to-swiftcompile-actions-even-when-using-explicit-modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with explicit modules, Swift compilations do not require any of the headers to be present on disk, because the AST contains all the necessary information (save for a bug(?) in
canImportwhich fails if the headers aren't also present). However, other tooling may want to inspect compilation actions and have access to those headers.This feature is a no-op for implicit module builds, since the headers are always included to begin with, and it is off by default.
PiperOrigin-RevId: 461668350
(cherry picked from commit 81f7b54)