Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of params files in _swift_proto_compile #1283

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fix usage of params files in _swift_proto_compile #1283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion proto/swift_proto_compiler.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ def _swift_proto_compile(label, actions, swift_proto_compiler_info, additional_c

# Build the arguments for protoc:
arguments = actions.args()
arguments.use_param_file("--param=%s")
arguments.set_param_file_format("multiline")
arguments.use_param_file("@%s")

# Add the plugin argument with the provided name to namespace all of the options:
plugin_name_argument = "--plugin=protoc-gen-{}={}".format(
Expand Down