Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding target name to output path for plugin executable #1294

Merged

Conversation

tymurmustafaiev
Copy link
Contributor

@tymurmustafaiev tymurmustafaiev commented Jul 17, 2024

Adding target_name to output path of swift plugin executable. Feature covered by SWIFT_FEATURE_ADD_TARGET_NAME_TO_OUTPUT flag.

Without this change and SWIFT_FEATURE_ADD_TARGET_NAME_TO_OUTPUT enabled, we have naming collisions as bazel makes executable file on root folder, and in this root folder we make our target_name folder with all other files like: swiftinterface, headers, etc.
By adding this change, we put executable in same target_name folder with all other generated files

…_plugins

# Conflicts:
#	swift/swift_compiler_plugin.bzl
@brentleyjones brentleyjones merged commit 66e5842 into bazelbuild:master Jul 17, 2024
15 checks passed
@brentleyjones
Copy link
Collaborator

Thanks!

tcamin pushed a commit to Subito-it/rules_swift that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants