-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a pure Swift runfiles library #1310
Open
cerisier
wants to merge
30
commits into
bazelbuild:master
Choose a base branch
from
cerisier:runfiles_library
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cerisier
force-pushed
the
runfiles_library
branch
from
September 18, 2024 11:33
4e8b878
to
adda967
Compare
cerisier
force-pushed
the
runfiles_library
branch
from
September 18, 2024 11:33
adda967
to
6518806
Compare
cerisier
force-pushed
the
runfiles_library
branch
from
September 18, 2024 11:33
6518806
to
ca0cd32
Compare
fmeum
reviewed
Sep 19, 2024
cerisier
requested review from
aaronsky,
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
January 4, 2025 09:17
cerisier
changed the title
Introduce a runfiles library
Introduce a pure Swift runfiles library
Jan 4, 2025
let runfiles = try Runfiles.create() | ||
|
||
// Runfiles lookup paths have the form `my_workspace/package/file`. | ||
// Runfiles path lookup may return nil. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which cases can it return nil
, and should it throw instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It returns nil in 2 scenarios:
- The runfiles path is relative
- No manifest entry for this path if using the manifest
I can make it throw instead indeed.
Co-authored-by: Brentley Jones <github@brentleyjones.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First shot at implementing #890
Main implementation
I followed guidance from @fmeum and based this implementation on the runfiles library of
rules_python
where applicable since this was pointed as the reference implementation.In addition to
rules_python
implementation, this implementation uses a similar mechanism as the C++ implementation for deducing theRUNFILES_DIR
andRUNFILES_MANIFEST_FILE
location based onargv0
.TODO