Add -Osize support #348
Merged
Add -Osize support #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a feature to use `-Osize` instead of `-O` which apparently should rarely have a major impact on "normal" apps' performance https://forums.swift.org/t/performance-impact-of-swift-compiler-optimization-level/30170/2
swiple-rules-gardener
pushed a commit
that referenced
this pull request
Nov 20, 2019
Swift toolchains now have a `swift_executable` attribute that lets the configurator replace the Swift driver used by the rules with a custom executable in their workspace. This can be useful for testing the build rules alongside compiler development, and since that file is part of the workspace and a proper input of actions, it also works correctly across remote build environments. Also remove the no-longer-used `SwiftToolchainInfo.clang_executable` field, now that linking has migrated to the `cc_common.link` API. RELNOTES: None. FUTURE_COPYBARA_INTEGRATE_REVIEW=#348 from keith:ks/osize 9f4202b PiperOrigin-RevId: 281380294
swiple-rules-gardener
pushed a commit
that referenced
this pull request
Nov 20, 2019
Swift toolchains now have a `swift_executable` attribute that lets the configurator replace the Swift driver used by the rules with a custom executable in their workspace. This can be useful for testing the build rules alongside compiler development, and since that file is part of the workspace and a proper input of actions, it also works correctly across remote build environments. Also remove the no-longer-used `SwiftToolchainInfo.clang_executable` field, now that linking has migrated to the `cc_common.link` API. RELNOTES: None. FUTURE_COPYBARA_INTEGRATE_REVIEW=#348 from keith:ks/osize 9f4202b PiperOrigin-RevId: 281380294
swiple-rules-gardener
added a commit
that referenced
this pull request
Nov 21, 2019
PiperOrigin-RevId: 281091576
|
Thanks! |
|
I don't know why it took this long—I merged this internally 3 days ago... |
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
PiperOrigin-RevId: 281091576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a feature to use
-Osizeinstead of-Owhich apparentlyshould rarely have a major impact on "normal" apps' performance
https://forums.swift.org/t/performance-impact-of-swift-compiler-optimization-level/30170/2