Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -fsystem-module if the compiler is new enough to support it (Xcode 12.5/Swift 5.4 or higher). #626

Conversation

keith
Copy link
Member

@keith keith commented May 28, 2021

PiperOrigin-RevId: 373046121
(cherry picked from commit 4cd9b2c)

…ode 12.5/Swift 5.4 or higher).

PiperOrigin-RevId: 373046121
(cherry picked from commit 4cd9b2c)
@keith keith marked this pull request as ready for review May 28, 2021 18:20
@google-cla
Copy link

google-cla bot commented May 28, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 28, 2021
keith referenced this pull request May 28, 2021
…ode 12.5/Swift 5.4 or higher).

PiperOrigin-RevId: 373046121
Comment on lines +74 to +79
# If enabled, the `-Xcc -fsystem-module` flag will be passed when compiling a
# system C/Objective-C module (with feature `swift.system_module`) because the
# compiler is new enough to honor it correctly. If disabled, we attempt to mimic
# this by disabling certain warnings; however, this unfortunately causes `UInt`
# APIs to be imported by ClangImporter as `UInt` instead of `Int` because
# ClangImporter doesn't recognize them as true system modules.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That took me so long to figure out 😅

@keith keith merged commit 8e63bad into master May 28, 2021
@keith keith deleted the ks/use-fsystem-module-if-the-compiler-is-new-enough-to-support-it-xcode-12.5-swift-5.4-or-higher branch May 28, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants