Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#185, add removeprefix/removesuffix to the spec #193

Merged
merged 2 commits into from
Feb 15, 2022
Merged

#185, add removeprefix/removesuffix to the spec #193

merged 2 commits into from
Feb 15, 2022

Conversation

ndmitchell
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label May 28, 2021
@stepancheg
Copy link
Contributor

This method was added in Python 3.9, I cannot even play with it on my laptop

Perhaps clarify that prefix is removed no more than once. (e. g. "aaaaaax".removeprefix("a") removes only first "a").

PEP: https://www.python.org/dev/peps/pep-0616/

@ndmitchell
Copy link
Contributor Author

Clarified as per your suggestion

@fmeum fmeum mentioned this pull request Feb 15, 2022
Closed
laurentlb
laurentlb approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(and sorry for the delay)

@laurentlb laurentlb merged commit d6a52c5 into bazelbuild:master Feb 15, 2022
@ndmitchell ndmitchell deleted the remove_prefix_suffix branch February 19, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentlb laurentlb laurentlb approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndmitchell @stepancheg @laurentlb