fix: Link the full label / file name instead of individual components #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogelsgesang
requested review from
coeuvre,
jfirebaugh and
cameron-martin
as code owners
cameron-martin
approved these changes
Apr 16, 2024
…t individually So far, the `go_to_definition` provider did not provide a `originSelectionRange`. Hence, VS Code was falling back on its internal tokenization to decide which part of the text to provide the HyperLink for. For the label "my/package:file.txt", we hence linked `my`, `package`, `file` and `txt` individually, all pointing to the same file. With this change, we now instead always provide the link on the full label.
vogelsgesang
force-pushed
the
avogelsgesang-link-complete-label-name
branch
from
1e8c8b5
to
527f2d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the
go_to_definitionprovider did not provide aoriginSelectionRange. Hence, VS Code was falling back on its internal tokenization to decide which part of the text to provide the HyperLink for.For the label "my/package:file.txt", we hence linked
my,package,fileandtxtindividually, all pointing to the same file.With this change, we now instead always provide the link on the full label.