Update to latest rules_scala, etc. #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we need to update bazel for travis. We require at least 0.14.1 now. |
|
Looks like the formatting test failed. Why did you remove the source dependencies? As you know, I prefer them and would rather go in the other direction (more source dependencies not fewer). |
|
I’ll merge with the source dep removals. I’ve been meaning to build up a repo of bazel build for scala projects. I can reintroduce then. |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This recent rules_scala PR replaces
@scala//:scala-compiler, etc. with@io_bazel_rules_scala_scala_compiler: bazelbuild/rules_scala#549Originally I thought we'd need to make a change here in bazel-deps to accommodate this change. We don't, but I noticed a lot of things were pretty far out of date, so I went ahead and did a quick update.
A coursier test fails for me locally but it fails in the same way on master.
This is a low-priority PR—nothing's waiting for it, it's just general hygiene.