Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SortedMap in GradleResolver, fix property tests #377

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

johnynek
Copy link
Collaborator

@johnynek johnynek commented Feb 2, 2024

once again, the fact that scalatest silently drops tests that return Boolean or Prop instead of doing assertions bit us.

if (right.size > left.size) rev.tryMerge(debugName, right, left)
else {
// right <= left in size
val overlaps = right.exists { case (k, _) => left.contains(k) }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this optimization doesn't make sense. In the case it helps, you have to go all the way through right. But if you are doing that, so is the next branch. Just go through the smaller on unconditionally.

@johnynek johnynek merged commit f18ecb2 into master Feb 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants