Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging for gradle resolver #378

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

johnynek
Copy link
Collaborator

@johnynek johnynek commented Feb 3, 2024

This does two main things:

  1. removes an annoying println in our logs about using VersionResolver. We have configured to use the "highest" conflict resolution. We don't need to println every time that runs. If we want to error, there is a VersionConflictPolicy for that: Fixed. I moved that println to a debug setting (which we can select with --verbosity debug to bazel-deps).
  2. adds a bit more info logging to make sure deleted edges were being seen.

@johnynek johnynek merged commit 2939a58 into master Feb 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants