Improve remapper cache #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous remapper implementation contained some branches in which the returned values weren't cached. Most importantly, when a name wasn't mapped, the `null` value returned in that case is persisted as `null` in the map and thus wasn't distinguishable from a cache miss with `get()`. This is worked around by using `computeIfAbsent`. Improves the JUnit benchmark's runtime by ~2%. The impact is larger when a larger fraction of identifiers isn't mapped by rules.
johnynek
approved these changes
Jan 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous remapper implementation contained some branches in which the returned values weren't cached. Most importantly, when a name wasn't mapped, the
nullvalue returned in that case is persisted asnullin the map and thus wasn't distinguishable from a cache miss withget(). This is worked around by usingcomputeIfAbsent.Improves the JUnit benchmark's runtime by ~2%. The impact is larger when a larger fraction of identifiers is mapped identically by rules.