Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyspell generates overlays for links and alike #49

Closed
TobiasZawada opened this issue Feb 8, 2024 · 3 comments
Closed

Flyspell generates overlays for links and alike #49

TobiasZawada opened this issue Feb 8, 2024 · 3 comments

Comments

@TobiasZawada
Copy link
Collaborator

Expected behavior

Links like image:ImageDir/myLovelyCat.png[] are not checked by Flyspell

Actual behavior

Currently, Flyspell puts overlays on links which are spelled erroneous.

Steps to reproduce the problem

Try the following Adoc:

== Title

Links like image:ImageDir/myLovelyCat.png[] are not checked by Flyspell

Adoc-Mode version information

adoc-mode, version 0.8.0-snapshot

Emacs version

GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2023-08-02, modified by Debian

@bbatsov
Copy link
Owner

bbatsov commented Feb 8, 2024

@TobiasZawada
Copy link
Collaborator Author

TobiasZawada commented Feb 8, 2024

This approach might be relevant https://emacs.stackexchange.com/questions/5415/how-can-i-make-flyspell-ignore-urls

I know the flyspell-mode-predicate property of major mode symbols and I have already a branch for it.
My first approach is to let font-lock mark the relevant spots with an adoc-flycheck-ignore text property and only test for this property in the predicate function. With other words: re-use all the hard work that font-lock already does anyway.

@TobiasZawada
Copy link
Collaborator Author

@bbatsov Before I create a pull request for this issue I would like to merge !48.

TobiasZawada pushed a commit that referenced this issue Feb 8, 2024
TobiasZawada pushed a commit that referenced this issue Feb 8, 2024
@bbatsov bbatsov closed this as completed in a2f6c82 Feb 8, 2024
TobiasZawada added a commit that referenced this issue Feb 10, 2024
Co-authored-by: Tobias Zawada <TOZ@esi-group.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants