Increase flexibility for inputs to crux-rename-file-and-buffer #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Just drop the |
`read-file-name` works great for existing file names, but this command is often used to renaming files to names that aren't currently used. If a user is using a completion backend like ido or helm, `read-file-name` will prompt them for an *existing* file name. Instead, allow them to input arbitrary strings.
Wilfred
force-pushed
the
rename_file_and_buffer_tweaks
branch
from
7bdd87d to
1967a75
Compare
|
Commits amended :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
crux-rename-file-and-bufferto:Let me know what you think. These are the only features my implementation has when I realised that crux can do this for me. I've separated these two changes into two commits in case you'd prefer only having one of these changes.