Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add category metadata to completing-read #1892

Merged

Conversation

juergenhoetzel
Copy link
Contributor

@juergenhoetzel juergenhoetzel commented May 26, 2024

I added the metadata only to the default Emacs completing-read. as I am not familiar with the 3rd party systems helm and ivy.

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

I'm not sure about checking the last 2 checkboxes. The changes are only visible if using third-party packages like
marginalia and embark which use the metadata.

projectile-switch-project without metadata:

image

with metadata:
image

@bbatsov bbatsov merged commit fb78b79 into bbatsov:master Aug 14, 2024
7 checks passed
@bbatsov
Copy link
Owner

bbatsov commented Aug 14, 2024

Cool improvement! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants