Fix searching ignored directories for ripgrep #1914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
projectile-ripgrep
does not properly hide directories ofprojectile-globally-ignored-directories
as mentioned in issue #1811 .projectile-ripgrep
produces following arguments for searching.I found that there are two problems:
'
--glob
option does not support-g
flag docstring, it says that it uses gitignore rulesIn this PR, I made both globally ignored file and directory names to be quoted with
'
and remove unnecessary regexp (^\
and$
) fromprojectile-globally-ignored-directories
. This results in making arguments such as...resulting with ripgrep properly ignoring contents of
projectile-globally-ignored-directories
.By the way I am new to emacs lisp, so feel free to edit my changes.
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test
)M-x checkdoc
warningsThanks!