Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make TODO file name configurable #1050

Closed
geniou opened this issue Apr 29, 2014 · 2 comments
Closed

make TODO file name configurable #1050

geniou opened this issue Apr 29, 2014 · 2 comments

Comments

@geniou
Copy link
Contributor

geniou commented Apr 29, 2014

I personally don't like the fact, that the TODO file has the name rubocop-todo.yml. For me it should be named .rubocop_todo.yml. What do you think about the idea to make it configurable - e.g. on call by rubocop --auto-gen-config .rubocop_todo.yml?

@jonas054
Copy link
Collaborator

I wish we had named the file .rubocop_todo.yml from the beginning, but I'm not sure if we can fix it now without creating confusion.

If we do decide to fix it, I'd prefer just generating the file with a leading dot, and issue a clear warning if there's an inherit_from with the old name.

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 29, 2014

👍 for renaming this permanently to .rubocop_todo.yml.

grubernaut added a commit to grubernaut/supermarket that referenced this issue Jun 12, 2014
Update RuboCop-todo list to new file format referenced in
[this](rubocop/rubocop#1050) issue.

Also fixes various minor style issues warning rubocop.

Inside RuboCop config file, fixes exclude syntax to eliminate warnings on rubocop runs.

Signed-off-by: "Jake Champlin" <jake.champlin.27@gmail.com>
grubernaut added a commit to grubernaut/supermarket-1 that referenced this issue Jun 19, 2014
Update RuboCop to new gem version (0.23.0).
Include New RuboCop file layout specified in [this](rubocop/rubocop#1050) issue.

Update Rakefile to use new RuboCop class definition.
From Rubocop to RuboCop.

Add new .rubocop_todo.yml file following new RuboCop file structure.

Signed-off-by: "Jake Champlin" <jake.champlin.27@gmail.com>
grubernaut added a commit to grubernaut/supermarket-1 that referenced this issue Jun 19, 2014
Update RuboCop to new gem version (0.23.0).
Include New RuboCop file layout specified in [this](rubocop/rubocop#1050) issue.

Update Rakefile to use new RuboCop class definition.
From Rubocop to RuboCop.

Add new .rubocop_todo.yml file following new RuboCop file structure.

Signed-off-by: "Jake Champlin" <jake.champlin.27@gmail.com>
gravitystorm added a commit to cyclestreets/cyclescape that referenced this issue Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants