Update RuboCop. Fix Minor Style Issues #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update RuboCop-todo list to new file format referenced in [this](rubocop/rubocop#1050) issue. Also fixes various minor style issues warning rubocop. Inside RuboCop config file, fixes exclude syntax to eliminate warnings on rubocop runs. Signed-off-by: "Jake Champlin" <jake.champlin.27@gmail.com>
Updates Gemfile for new RuboCop version 0.23.0 Signed-off-by: "Jake Champlin" <jake.champlin.27@gmail.com>
|
Build Passes with new Gemfile. |
|
Thanks @grubernaut! This all seems reasonable to me. @bcobb @raskchanky do you have any objections? |
|
I'd be lying if I said I was a huge fan of the underscored parameter names, though I do understand the purpose. |
|
No objections here. |
|
Imma gonna merge it then. I'm also not the hugest fan of underscored parameter names but I think this PR has some other goodness that makes it worth it. |
tristanoneil
added a commit
that referenced
this pull request
Jun 13, 2014
Update RuboCop. Fix Minor Style Issues
|
👍 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update RuboCop-todo list to new file format referenced in
this issue.
Also fixes various minor style issues warning rubocop.
Inside RuboCop config file, fixes exclude syntax to eliminate warnings on rubocop runs.
Signed-off-by: "Jake Champlin" jake.champlin.27@gmail.com