Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor of gsub to delete fails #2212

Closed
slowjack2k opened this issue Sep 5, 2015 · 2 comments
Closed

Refactor of gsub to delete fails #2212

slowjack2k opened this issue Sep 5, 2015 · 2 comments

Comments

@slowjack2k
Copy link

Hi,

I used rubocop 0.34.0, ruby 2.2.2p95 with the following construct :

rubocop -a

# Before rubocop
Base64.encode64(mac.digest).gsub "\n", ''

# After rubocop
 Base64.encode64(mac.digest).delete "\n")

It's seems like the cop did miss a brace.
@karreiro
Copy link
Contributor

karreiro commented Sep 5, 2015

Fixed 😄

@slowjack2k
Copy link
Author

Thx :)

@bbatsov bbatsov closed this as completed in 7bdcd16 Sep 6, 2015
bbatsov added a commit that referenced this issue Sep 6, 2015
@bbatsov
Merge pull request #2216 from karreiro/autocorrect_parentheses_bug
cb00a0c 
[Fix #2212] Handle methods without parentheses in auto-correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slowjack2k @karreiro