[Fix #2212] Handle methods without parentheses in auto-correct #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karreiro
force-pushed
the
autocorrect_parentheses_bug
branch
2 times, most recently
from
f300802 to
10f407c
Compare
| @@ -36,6 +36,7 @@ | |||
|
|
|||
| ### Bug Fixes | |||
|
|
|||
| * [#2212](https://github.com/bbatsov/rubocop/issues/2212): Handle methods without parentheses in auto-correct. ([@karreiro][]) | |||
There was a problem hiding this comment.
This should be in the master section of the changelog.
karreiro
force-pushed
the
autocorrect_parentheses_bug
branch
from
10f407c to
0b9b6d0
Compare
| @@ -1,6 +1,7 @@ | |||
| # Change log | |||
|
|
|||
| ## master (unreleased) | |||
| * [#2212](https://github.com/bbatsov/rubocop/issues/2212): Handle methods without parentheses in auto-correct. ([@karreiro][]) | |||
There was a problem hiding this comment.
This should be in the "Bug Fixes" section a couple of lines down.
karreiro
force-pushed
the
autocorrect_parentheses_bug
branch
from
0b9b6d0 to
7bdcd16
Compare
bbatsov
added a commit
that referenced
this pull request
Sep 6, 2015
[Fix #2212] Handle methods without parentheses in auto-correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to
StringReplacementa condition for checking if the method has an opening parentheses, before adding the ')' in the end of the new call.