Improve rubocop todo #693
Improve rubocop todo #693
Conversation
|
Coverage decreased (-0.01%) when pulling d6e302128d99aa624f340f6d78bbb8f087d3d2b6 on jonas054:improve_rubocop_todo into ab06b29 on bbatsov:master. |
| IndentationWidth::CORRECT_INDENTATION - expected_indent_offset | ||
| end | ||
|
|
||
| def other_style |
There was a problem hiding this comment.
complementing_style or alternative_style would be a better name.
|
I like the general direction of the change. I'd suggest that the logic selecting a style in many cops (usually a switch on |
|
Good comments. I've made separate commits that I'll squash when you think everything is OK. |
|
Coverage increased (+0.13%) when pulling 50d4d7c57b53c7b912929772fe3cfb986f9ac779 on jonas054:improve_rubocop_todo into ab06b29 on bbatsov:master. |
|
Coverage increased (+0.13%) when pulling 2382e322224e8b190105237f850b0215bd72fee6 on jonas054:improve_rubocop_todo into ab06b29 on bbatsov:master. |
|
OK now? |
|
Coverage increased (+0.11%) when pulling d0828e76b81152804c034de1980c59ce66b1adf3 on jonas054:improve_rubocop_todo into ab06b29 on bbatsov:master. |
|
Yes. — On Sun, Dec 22, 2013 at 6:21 PM, Coveralls notifications@github.com
|
All the Max parameters and some EnforcedStyle parameters can now be generated into rubocop-todo.yml. More can be added later. These parameters are generated instead of Enabled:false, making the available configuration options more visible.
|
Fixed one more thing. There was a double definition of |
I've been thinking that we should be able to do better than just generating
Enabled: falseinrubocop-todo.yml. Here's an implementation that setsMax(for all cops that have aMax) andEnforcedStyle(for some that have it).So I haven't gone all the way and implemented the functionality for all configurable cops. I wanted to see what people think of it first. It does require a little bit of code added to the cops.