Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary constants #1770

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Remove unnecessary constants #1770

merged 1 commit into from
Jan 5, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Jan 5, 2024

Perhaps, but it appears to be a constant that is not used now.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah ydah requested a review from a team as a code owner January 5, 2024 14:26
@ydah
Copy link
Member Author

ydah commented Jan 5, 2024

❯ find . -type f -print | xargs grep 'SUPPORTED_STYLES' 
./lib/rubocop/cop/rspec/message_expectation.rb:        SUPPORTED_STYLES = %w[allow expect].freeze
./lib/rubocop/cop/rspec/message_spies.rb:        SUPPORTED_STYLES = %w[have_received receive].freeze

@bquorning
Copy link
Collaborator

Where do they come from? I found the same constant mentioned in rubocop, but didn’t find out why.

Copy link
Collaborator

@bquorning bquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found SUPPORTED_STYLES mentioned in rubocop/rubocop#693, but only in specs 🤷🏼

@ydah ydah merged commit 297a3a2 into master Jan 5, 2024
24 checks passed
@ydah ydah deleted the remove-constants branch January 5, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants