Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to cmake #3

Merged
merged 32 commits into from
Jan 25, 2023
Merged

Switch to cmake #3

merged 32 commits into from
Jan 25, 2023

Conversation

philipnbbc
Copy link
Collaborator

@philipnbbc philipnbbc commented Jan 13, 2023 •
edited
Loading

This introduces the following changes:

  • the autoconf and Microsoft Visual Studio C++ project files have been replaced with cmake
    • tests are now supported on all platforms
    • requires cmake version >= 3.12, which means Visual Studio C++ 2017 (updated) or later is supported
  • the libMXF and libMXF++ projects are included as submodules
    • All the code can now built, tested and installed from the bmx repo
  • the shared object versions and include paths no longer have the -1.0 suffixes
    • e.g. libbmx-1.0.so changes to libbmx.so and include directory bmx-1.0/bmx changes to bmx
  • code paths in log messages are now relative to the source root path and not absolute paths
  • library major and minor versions are set in the top-level CMakeLists.txt. The (MXF) patch version is the git commit offset from the last release tag.
    • The patch version will therefore count up until the next release is made which adds a new tag to git
  • Updated MXFDump to the latest version in the AAF SDK
  • fixed various memory leaks found by valgrind
  • fixed various warnings when building on non-Ubuntu platforms

@philipnbbc
Add libMXF and libMXFpp submodules
3de896a
@philipnbbc
Add cmake build scripts
c8e497c
@philipnbbc
Remove legacy build and test files
70b8c4b
@philipnbbc
Add missing memory deallocs spotted by valgrind
4be5aa8
@philipnbbc
Replace forward with backward slash for file URI
393259d 
This avoids uriWindowsFilenameToUriStringA escaping them in the URI
when they are most likely intended to be path separators.
@philipnbbc
Explicit type casts to avoid MSVC warnings
774405f
@philipnbbc
Build apps and tools by default
f79e6d4
@philipnbbc
Add large file support compiler flags
8c3d65e
@philipnbbc
Various updates to support older platform/cmake
1993125
@philipnbbc
Use cmake ARCHIVE and LIBRARY install destinations
fad4ffd
@philipnbbc
Add MSVC /EHsc flag (for VS 2017) to fully unwind stack
e13a041
@philipnbbc
Add a large file (>4GB) test
17abe50
@philipnbbc
Catch missing libMXF/pp deps earlier
a4e7132
@philipnbbc
Remove unused source file AS11Labels.cpp
a7279e1
@philipnbbc
Modify top CMakeLists because MSVC only defined after project
d4cbc10
@philipnbbc
Update Dockerfile to use cmake build
c3010c7
@philipnbbc
Update README for cmake build
3f67edb
@philipnbbc
Ensure git checkout uses LF for test text files
f432116 
git on Windows (2.38.1.windows.1) was found to have 'core.autocrlf' set to 'true'
(in the global gitconfig), which resulted in files detected as text to be be
checked out (e.g. as part of the repo clone) with CRLF line endings. That then
broke the tests that rely on checksums and reference text files because the input
data had changed.

The use of .gitattributes and "text eol=lf" attributes did nothing to change
that for the existing test files! Confusingly it did work for new
files checked into the repo?! 'git check-attr -a' and 'git ls-files --eol'
did not show any diference between the existing and new files.

This commit does the "proper thing", which is use .gitattributes
to indicate files that should be checked out with LF line endings.
To workaround git ignoring these attributes, a '.bin' suffix is added to
the text filenames to stop git detecting it as text and using CRLF anyway
on checkout.
@philipnbbc
Ignore unused variable warning from clang
8b83d33
@philipnbbc
Remove register deprecated in c+11 and removed/reserved in c++17
a08a5f7
@philipnbbc
Fix deprecated ptr_fun by using trim_string instead
b16ad59
@philipnbbc
Replace __FILE__ with __FILENAME__ relative project path
f8d0d8a
@philipnbbc
Update libMXF and libMXFpp submodules
8f3d17a
This was referenced Jan 25, 2023
Merged
Merged
@philipnbbc philipnbbc merged commit a6c7e1c into main Jan 25, 2023
@philipnbbc philipnbbc deleted the philipn-cmake branch January 25, 2023 10:25
@FranceBB FranceBB mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@philipnbbc