Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmxf: use cmake vars to set default platform name #84

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philipnbbc
Copy link
Collaborator

The platform name is used in the (human readable) MXF Identification::Platform property value. This commit keeps the existing names for known platforms defines to avoid breaking scripts that (wrongly) rely on it. If the platform is not known then the name is provided by CMAKE's CMAKE_SYSTEM_NAME and CMAKE_SYSTEM_PROCESSOR variables.

Fixes #83

The platform name is used in the Identification::Platform property
value. This commit keeps the existing names for known platforms,
but uses the names provided by CMAKE if the platform is unknown.
@philipnbbc
Copy link
Collaborator Author

I might need to take another look at this because I'm guessing this won't work for macOS Universal binaries as the config.h file is created at configure time.

@philipnbbc philipnbbc marked this pull request as draft June 27, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include "macOS" in ApplicationPlatform of Identification
1 participant