-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests (and fix implementation for) EBU-TT-D style conversion #34
Conversation
…s with referenced styles at the same level
…style hierarchy in order.
…yword argument assignment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some pretty minor changes requested, this mostly looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that when I run make test
on this branch the new tests aren't run. I'm not sure why test_ebuttd_required_metadata.py
and test_ebuttd_style_references.py
are not picked up. My terminal output goes straight past them. Here's an excerpt:
testing/bdd/test_documentMetadata_elements_order.py .......... [ 19%]
testing/bdd/test_elements_active_times.py .............................................................................................. [ 32%]
Sorry, my bad, they're running fine. |
Not sure quite what this metadata does, but the other BDDs have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good, sorry I've added a few "down in the weeds" comments to keep things tidy, but this functionally works, so once those last minor tweaks are done this will be good to merge.
…s... - and check that only one style/region element exists before checking attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the previous review comments @danpope-bbc ! Looking good to squash and merge, I think.
This checks that, when converted from EBU-TT-Live to EBU-TT-D, the
styling > style
elements do not contain nested references. Instead the styling information contained in referenced styles should be merged with the parent style, keeping the original style ID.So if there are 4 style elements like so:
Then the converted document will contain style s4 with all the elements of s3, s2 and s1 with priority to the attributes of s4 > s3 > s2 > s1.
This PR also moves padding defined in
<style>
elements to their corresponding<region>