MSPA 427 attributes #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Self-review comments: needs a unit test for the ElementRemover, and needs some additional functionality to meet remaining requirements of the MSPA-427 ticket. Not assigning a reviewer until I've done those bits. |
|
My plan is to do the remaining parts of the (BBC specific) ticket in the BBC specific code, in which case this is good to review. Will assign a reviewer! |
|
By the way, for review purposes, it might make sense to wait until #43 has been merged, since this branch is based off that PR's branch, and the deltas will be easier to understand. |
…seding class on document creation
MSPA-728 ebu-tt-3 to ebu-tt-d conversion
…seding class on document creation
Does not handle time conversion. Sets `ebuttp:sequenceIdentifier` to the value of `tt/head/metadata/documentMetadata/documentIdentifier` if present, otherwise uses "TestConverter". Resets the `conformsToStandard` to say it is EBU-TT-3 conformant. Sets the `timeBase` to `media` whether you like it or not, but doesn't do any other conversions.
Also allows for a setting that specifies whether or not to use `ebuttm:documentIdentifier` element value in the input as the `ebuttp:sequenceIdentifier` attribute value in the output. Adds a test for this.
Unit test for this also added. Tidy out some print statements that had made their way in there.
The docs in current state don't build properly because autodoc throws a "cannot import name `EBUTT1EBUTT3Converter`" exception. This is possibly a problem with circular `import` references, which should be resolved before we merge. This can be demonstrated by adding `from . import ebutt1_ebutt3` to `ebu_tt_live/bindings/converters/__init__.py` and running `python -m ebu_tt_live.bindings.converters` which shows a stack trace illustrating the issue.
nigelmegitt
force-pushed
the
mspa-427-attributes
branch
from
09021dd to
cb3e9ea
Compare
|
Rebased on |
* Don't process duplicate documents * Don't process documents from more than one sequence * Factor out element removal from sequence processing so we can have a returning method that can be called independently of `process_document` in case the node's functionality is needed without providing a concrete carriage mechanism.
* Move project-wide data to a single file so we can import it * Import it into the doc generation `conf.py` and the `setup.py` - great, updating the version now only needs one line of code to change!
danielthepope
requested changes
Dec 3, 2019
Addresses review comments.
And quieten flake8 down
Addresses review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for removing unwanted elements.
Creates an ElementRemover node that takes a comma separated list of elements to be removed. This PR includes an example configuration script that removes the relevant set of metadata elements.