Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPLAYER-43503: Fix typo in and optionify arg passed to toJson method declaration file. #44

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

yusuf963
Copy link
Contributor

@yusuf963 yusuf963 commented Nov 20, 2023

Description

Motivation and Context

Fix typo in and optionlify arg passed to toJson method declaration file

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.~
  • [ ] I have added tests to cover my changes.
  • All new and existing tests passed.

@yusuf963 yusuf963 requested a review from a team as a code owner November 20, 2023 14:46
Copy link
Member

@simongregory simongregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! retries should be retry and the intention for opts to be potentially empty is implied on the first line of the middleware itself.

@jamierbower jamierbower changed the title IPLAYER-43503: Fix typo in and optionlify arg passed to toJson method declaration file. IPLAYER-43503: Fix typo in and optionify arg passed to toJson method declaration file. Nov 20, 2023
@Simon2828 Simon2828 merged commit 9b8c3fa into bbc:main Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants