Set parent container's data focus #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Abbi Grundy <abbigrundy@users.noreply.github.com>
Co-authored-by: Abbi Grundy <abbigrundy@users.noreply.github.com>
Co-authored-by: Murray Coghill <Murreey@users.noreply.github.com>
jordanholt
approved these changes
Jun 5, 2024
victoria30abc
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor how we set data focus, so that when you move into a focusable container it sets the data-focus of that focusable container to also point to the same item your focus eventually landed on.
Rewrote the README a bit for clarity too
Motivation and Context
When moving between multiple nested containers, you previously could end up with lots of different data-focuses at each level that you move through. This'd sometimes mean if you moved your focus out of a focusable container then back in via the same thing, you'd lose the focus history because it hadn't been stored on the parent.
How Has This Been Tested?
New unit tests, and has been running in test for a while now.
Checklist: