Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent BBC definition of focusableSelector #48

Closed
wants to merge 1 commit into from
Closed

Use consistent BBC definition of focusableSelector #48

wants to merge 1 commit into from

Conversation

NickGoward
Copy link
Contributor

Description

Use focusableSelector as per other BBC definitions

Motivation and Context

For consistency, use the same definition of what is focusable
No change in functionality

How Has This Been Tested?

Existing tests pass

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@NickGoward NickGoward requested a review from a team as a code owner September 10, 2024 15:24
@NickGoward NickGoward changed the title Use focusableSelector as per other BBC definitions Use consistent BBC definition of focusableSelector Sep 10, 2024
@NickGoward
Copy link
Contributor Author

Decided against using :not() selectors for compatibility

@NickGoward NickGoward closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Murreey Murreey Murreey approved these changes

@terminal-overflow terminal-overflow terminal-overflow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickGoward @Murreey @terminal-overflow