Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override existing index pages #91

Conversation

paulbrimicombe
Copy link
Contributor

@paulbrimicombe paulbrimicombe commented Jan 19, 2024

🧐 What?

  • Don't generate an index file for a directory if one has already been provided in the source repository

🛠 How

  • Test whether an index.html file already exists in a folder before generating one

🐞 Related issue

#90

📓 Notes

  • I've upgraded jest because the existing version wouldn't run on the latest version of Node JS 18 — see this build
  • I also ran npm audit fix to fix the security vulnerabilities

@kevin-castillo-bbc kevin-castillo-bbc requested a review from a team January 19, 2024 11:05
Copy link
Contributor

@stephegn stephegn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the note to the README. When the tests pass (and after lunch 😅) I'll get this merged and tagged.
I'll probably wait for your other PR before getting this pushed out to our internal system.

@kevin-castillo-bbc kevin-castillo-bbc merged commit 23f3569 into bbc:main Jan 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants