-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with the resizing of segments. #479
Comments
I think you're right, so I have reduced the tolerance. I could also add an option to set the tolerance, if needed. |
Thanks @chrisn for helping out. Appreciate it. So, which version should I use to implement this? |
I'll update this issue when a new release is available. But for the time being, I suggest applying the change in 246f793 to your own local copy. |
v3.0.0-beta.7 is now available in npm |
Thanks @chrisn for the help. I think you have not provided the option of changing the value of tolerance via options or something, Right? |
Not yet, but it can be added. It should probably be the same as |
Hi, @chrisn Continuing this discussion further. |
The difficulty here is that when two segments are adjacent with no separation between them, the segment being resized may not be the one the user expects. The position of the time label gives an indication, but it's not very clear to the user what's going on. In practice, segments are objects with a z-order and so it's the one at the top of the z-order. This issue may not be as simple as changing the tolerance for where the double arrow appears. I welcome any thoughts and suggestions! |
Hey I am using peaks v3.0.0-beta.6. While resizing the segments you can see the double sided arrow. Arrow is showing for much greater area than it should. For example, I have attached the screenshotsbelow from your demo overlay segments.
As you can see in the screenshots, my cursor is very far from the start time of segment still cursor is considering that it is on the starting of it and showing me the cursor used in resizing the segment. Can you tell me if there is any way that can be applied to improve this so that the cursor changes into double sided arrow only when i have it on the exact time stamp of start time?
The text was updated successfully, but these errors were encountered: