Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make is_key_frame and temporal_offset optional #150

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Make is_key_frame and temporal_offset optional #150

merged 2 commits into from
Jan 30, 2024

Conversation

philipnbbc
Copy link
Contributor

Details

This PR

  • increments the GSF version to 9
  • allows unknown values for is_key_frame and temporal_offset in GSF and Grains
    • this allows grain consumers to decide what logic to use whereas before it wasn't possible to decide whether the value was actually set or just the default
  • adds an option to gsf_probe to dump all grains rather than only the first one

Pivotal Story

Story URL: https://www.pivotaltracker.com/story/show/186608373

Related PRs

Where appropriate. Indicate order to be merged.

Links to external test runs/working deployment

Where appropriate, if separate to default CI run

Submitter PR Checks

(tick as appropriate)

  • Added bbc/rd-apmm-cloudfit team as a reviewer
  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • New features and API breaks are flagged in commit messages using magic strings
  • Documentation updated (README, Confluence, Docstrings, API spec, Engineering Guide, etc.)
  • Downstream repos have been checked for potential breaks & fixed as needed
  • APIs/UIs/CLIs updated as required
  • PR added to Pivotal story
  • Follow-up stories added to Pivotal
  • Any temporary code/configuration removed (e.g. test deployment environment, temporary commontooling branch)
  • Any pins against pre-releases have been removed

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on Cloudfit PRs

@philipnbbc
Support null is_key_frame and temporal_offset
5c48fd9 
GSF version changed to 9.

This change supports cases where is_key_frame and temporal_offset are
unknown, e.g. the processor that encapsulated the media in grains was
not capable emough to extract the info. Readers are then able to
decide to process the media differently if the values are known to be
unknown.

sem-ver: api-break
@philipnbbc
extract_gsf: add option to dump all grains
d6618a6
@philipnbbc philipnbbc force-pushed the philipn-optional-keyframe-temporaloffset branch from a01cb34 to d6618a6 Compare January 26, 2024 09:59
@philipnbbc philipnbbc requested a review from a team January 26, 2024 11:33
C-Lunn
C-Lunn approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@C-Lunn C-Lunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@philipnbbc philipnbbc merged commit 34ce5f3 into main Jan 30, 2024
6 checks passed
@philipnbbc philipnbbc deleted the philipn-optional-keyframe-temporaloffset branch January 30, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C-Lunn C-Lunn C-Lunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipnbbc @C-Lunn