Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require later python version 3, >= 3.6 #43

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Require later python version 3, >= 3.6 #43

merged 1 commit into from
Feb 18, 2020

Conversation

philipnbbc
Copy link
Contributor

from hypothesis.strategies import integers, lists failed in Python 3.5, #42, because of a bug: vega/altair#972.

Pivotal: https://www.pivotaltracker.com/story/show/170947695

@philipnbbc philipnbbc requested a review from a team February 17, 2020 10:34
@philipnbbc philipnbbc mentioned this pull request Feb 17, 2020
Merged
@AndrewGibb AndrewGibb self-assigned this Feb 18, 2020
AndrewGibb
AndrewGibb approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@AndrewGibb AndrewGibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It's a shame pyenv doesn't allow us to specify latest minor version on eg 3.6. A minor piece of brittleness we need to remember.

@philipnbbc philipnbbc merged commit 70d5e19 into master Feb 18, 2020
@philipnbbc philipnbbc deleted the philipn-require-py36 branch February 18, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGibb AndrewGibb AndrewGibb approved these changes

Assignees

@AndrewGibb AndrewGibb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipnbbc @AndrewGibb